Support empty invert_mask in measument gate deserialization #6224
Conversation
NoureldinYosri
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
NoureldinYosri
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6224 +/- ##
==========================================
- Coverage 97.36% 97.35% -0.01%
==========================================
Files 1116 1116
Lines 95700 95708 +8
==========================================
Hits 93181 93181
- Misses 2519 2527 +8
☔ View full report in Codecov by Sentry. |
|
Can you explain what legacy behavior this is restoring? I am not sure I understand what got broken. |
NoureldinYosri
changed the title
arg serialization
|
@dstrain115 An empty list This breaks measurement gate deserialization when the invertion mask is empty because during serialization it's not set. so during deserialization the value becomes |
NoureldinYosri
changed the title
arg serialization
cirq-google/cirq_google/serialization/circuit_serializer_test.py
Outdated
Show resolved
Hide resolved
| arg_function_language=arg_function_language, | ||
| required_arg_name=None, | ||
| ), | ||
| invert_mask_ = arg_func_langs.arg_from_proto( |
There was a problem hiding this comment.
Having invert_mask and invert_mask_ is pretty confusing. Can we give one a better name?
There was a problem hiding this comment.
renamed to parsed_invert_mask
No description provided.